-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt agent metadata to latest changes requested #290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cborla
reviewed
Nov 12, 2024
Nicogp
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TomasTurina
force-pushed
the
fix/256-add-name-to-register
branch
from
November 12, 2024 23:28
3f40343
to
69ab7f8
Compare
cborla
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jr0me
force-pushed
the
fix/256-add-name-to-register
branch
3 times, most recently
from
November 13, 2024 12:38
4485ce8
to
3ab8b5c
Compare
Due to recent changes in the agent's info implementation, where the sql logic was replaced with the SQLiteManager, a bug was introduced in the ResetToDefaults method by which the AgentInfo tables were not being cleaned up.
jr0me
force-pushed
the
fix/256-add-name-to-register
branch
from
November 13, 2024 12:45
3ab8b5c
to
e8a87b2
Compare
TomasTurina
force-pushed
the
fix/256-add-name-to-register
branch
from
November 13, 2024 15:02
06435b3
to
5e5190c
Compare
Nicogp
approved these changes
Nov 13, 2024
sdvendramini
approved these changes
Nov 13, 2024
aritosteles
approved these changes
Nov 13, 2024
jr0me
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes/improvements:
name
to the agent metadata.ip
as an array in the agent metadata.getNextNAwaitable
to return multiple messages.Tests
Examples